Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (DatePicker & Cascader): fix the dropdown animation direction of cascader and datepicker #21806

Merged
merged 2 commits into from Jun 2, 2022
Merged

fix (DatePicker & Cascader): fix the dropdown animation direction of cascader and datepicker #21806

merged 2 commits into from Jun 2, 2022

Conversation

XivLaw
Copy link
Contributor

@XivLaw XivLaw commented Apr 15, 2022 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

Fix: #21802
fix the dropdown animation direction of cascader and datepicker

before
GIF 2022-4-16 0-08-36

fixed
GIF 2022-4-16 0-37-55

@xinguanhua xinguanhua merged commit 807e208 into ElemeFE:dev Jun 2, 2022
@lqzhgood
Copy link
Contributor

lqzhgood commented Jun 6, 2022

升级以后报错了，应该是直接修改了 props placement

[Vue warn]: Avoid mutating a prop directly since the value will be overwritten whenever the parent component re-renders. Instead, use a data or computed property based on the prop's value. Prop being mutated: "placement"

found in

---> <ElDatePicker> at packages/date-picker/src/picker.vue

This was referenced Jun 6, 2022
Open
Merged
xinguanhua pushed a commit that referenced this pull request Aug 18, 2022
@lqzhgood
DatePicker: fix modify props "placement" error (#21908)
813abce 
this PR #21806 erroneously changed "placement" `data` -> `props`
@yangbuyiya
Copy link

尼玛的乱搞是吧

hzsrc pushed a commit to hzsrc/element that referenced this pull request Feb 2, 2023
@XivLaw
DatePicker & Cascader: fix the dropdown animation direction (ElemeFE#…
10e567f 
…21806)
hzsrc pushed a commit to hzsrc/element that referenced this pull request Feb 2, 2023
@lqzhgood
DatePicker: fix modify props "placement" error (ElemeFE#21908)
9bb6152 
this PR ElemeFE#21806 erroneously changed "placement" `data` -> `props`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@XivLaw @lqzhgood @yangbuyiya @xinguanhua